Uploaded image for project: 'StoRM'
  1. StoRM
  2. STOR-1393 Cleanup frontend codebase II
  3. STOR-1302

Review the Monitor class and see if it needs to be polymorphic

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Unresolved
    • Icon: Major Major
    • None
    • None
    • frontend
    • Security Level: Public (Visbile by non-authn users.)
    • None

      Monitor is meant to be polymorphic, but its only virtual function is the destructor (see also https://github.com/italiangrid/storm-frontend/commit/728561c7a95106fd249135608fe44c29f080af02). However its only derived class is InstrumentedMonitor and C-style casts are used instead of virtual functions (see e.g. https://github.com/italiangrid/storm-frontend/blob/e4d5d975672d14ba883297949bded68aea73fadc/src/frontend/MonitorHelper.hpp#L39)

            giaco Francesco Giacomini
            giaco Francesco Giacomini
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: