Uploaded image for project: 'StoRM'
  1. StoRM
  2. STOR-1342 Cleanup frontend codebase
  3. STOR-1191

memory leak in ns1__srmStatusOfPutRequest

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Major Major
    • None
    • None
    • frontend
    • Security Level: Public (Visbile by non-authn users.)
    • None

      The address sanitizer reports an indirect memory leak in ns1__srmStatusOfPutRequest

      #0 0x7f143be752ef in operator new(unsigned long) (/lib64/libasan.so.5+0x10e2ef)
      #1 0x54e3ef in ns1__srmStatusOfPutRequest /home/centos/storm-frontend.git/src/frontend/asynch_status.cpp:48
      

      which corresponds to the line:

      request = new storm::PutStatusRequest(soap, req);

      I don't know what "indirect" means, but certainly the raw pointer is not safe in presence of early returns (including exceptions) in the following code. Better use a smart pointer.

            giaco Francesco Giacomini
            giaco Francesco Giacomini
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: