curl_global_init should be called before spawning threads

XMLWordPrintable

    • Type: Story
    • Resolution: Fixed
    • Priority: Major
    • 1.11.18
    • Affects Version/s: 1.11.17
    • Component/s: frontend
    • Security Level: Public (Visbile by non-authn users.)
    • None

      From the manual of curl_global_init:

      This function is not thread safe. You must not call it when any other thread in the program (i.e. a thread sharing the same memory) is running. This doesn't just mean no other thread that is using libcurl. Because curl_global_init calls functions of other libraries that are similarly thread unsafe, it could conflict with any other thread that uses these other libraries.

      But in storm-frontend.cpp the function is called after spawning all the threads in the thread pool.

      The operations should be inverted.

            Assignee:
            Francesco Giacomini
            Reporter:
            Francesco Giacomini
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: