Cleanup frontend codebase II (STOR-1393)

[STOR-1388] requestFailure/requestSuccess may be used uninitialized in srmv2_GetRequestSummary.cpp Created: 29/Mar/21  Updated: 27/May/21

Status: Open
Project: StoRM
Component/s: frontend
Affects Version/s: None
Fix Version/s: None
Security Level: Public (Visbile by non-authn users.)

Type: Sub-task Priority: Major
Reporter: Francesco Giacomini Assignee: Francesco Giacomini
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

The compiler warns that

 

srmv2_GetRequestSummary.cpp: In function ‘int ns1__srmGetRequestSummary(soap*, ns1__srmGetRequestSummaryRequest*, ns1__srmGetRequestSummaryResponse_*)’:
srmv2_GetRequestSummary.cpp:344:12: warning: ‘requestFailure’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     } else if (requestFailure) {
            ^~
srmv2_GetRequestSummary.cpp:340:5: warning: ‘requestSuccess’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     if (requestSuccess) {
     ^~

Very likely the two variabilized are in fact initialized when used, because the control flow would exit earlier if something fails before the initialization. Confirmation is needed, though.

In any case, the warning needs to be fixed.

 

 

 

 

 Comments   
Comment by Francesco Giacomini [ 27/May/21 ]

It's part of a second bunch of cleanup issues. Not addressed yet.

Generated at Thu Apr 10 10:24:35 CEST 2025 using Jira 10.3.4#10030004-sha1:d6812f2d35a143c1c5fc283d2f5a72582f40aaf1.